Host L1 txs: one-at-a-time to remove nonce risk #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Currently we try to optimistically manage L1 account nonce on the host. We only resync it to chain data on restart.
This has recently started to cause a conflict on ten-sepolia where rollup tx start failing continuously because the nonce is off.
Currently the only L1 transactions produced by the host are rollups and secret responses, there's no need to have multiple in flight simultaneously. Both the rollups and the secret exchange protocols can recover from delayed or dropped transactions.
What changes were made as part of this PR
Limit host to one L1 tx in flight at a time, blocking for the next one. This only adds contention at testnet network initializations really, when secret exchanges can be happening simultaneously as nodes start up.
The sim tests currently start the most nodes and we see a 10second increase in that test length with this change which seems reasonable for the simplification.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks