WIP Add Geth RPC to the gateway #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- align some methods with the geth rpc types
# Conflicts: # tools/walletextension/accountmanager/account_manager.go # tools/walletextension/subscriptions/subscriptions.go # tools/walletextension/wallet_extension.go
# Conflicts: # tools/faucet/faucet/faucet.go # tools/walletextension/accountmanager/account_manager.go # tools/walletextension/subscriptions/subscriptions.go # tools/walletextension/wallet_extension.go
tudor-malene
commented
Mar 20, 2024
# Conflicts: # tools/walletextension/frontend/src/components/head-seo.tsx
…tudor/OG_geth_RPC # Conflicts: # tools/walletextension/common/constants.go # tools/walletextension/wallet_extension.go
# Conflicts: # integration/obscurogateway/tengateway_test.go # tools/walletextension/httpapi/routes.go # tools/walletextension/test/apis.go # tools/walletextension/wallet_extension.go
# Conflicts: # go/common/viewingkey/viewing_key.go # go/common/viewingkey/viewing_key_messages.go # go/common/viewingkey/viewing_key_signature.go # go/enclave/vkhandler/vk_handler.go # tools/walletextension/common/constants.go
| return nil | ||
| } | ||
|
|
||
| func decodeAddress(s string) (common.Address, error) { |
There was a problem hiding this comment.
This feels iffy - if the hex decode fails the error is set, but we return both attempted bytes conversion plus the error.
There was a problem hiding this comment.
it's copy paste from geth. I needed to change that Unumarshall
| type MessageGenerator interface { | ||
| generateMessage(encryptionToken string, chainID int64, version int) ([]byte, error) | ||
| generateMessage(encryptionToken []byte, chainID int64, version int) ([]byte, error) |
There was a problem hiding this comment.
This needs comments
There was a problem hiding this comment.
good point. One for @zkokelj
zkokelj
requested changes
Mar 26, 2024
| @@ -1,4 +1,4 @@ | |||
| package faucet | |||
| package obscurogateway | |||
There was a problem hiding this comment.
obscurogateway -> tengateway for the whole package
There was a problem hiding this comment.
I just aligned it with the folder name. Let's change this as part of a smaller pr
BedrockSquirrel
approved these changes
Mar 27, 2024
zkokelj
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Replace the "proxy" approach of the Gateway with the type-safe RPC implementation of geth.
This helps structure the business logic and clarify responsibilities.
What changes were made as part of this PR
[]byteeverywhere. Previously, we were converting between string/byte in various ways.account managerconcept and rely on the database to fetch data in real-time.PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks
https://github.com/ten-protocol/ten-test/actions/runs/8450782099/job/23147694242