Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security headers #1847

Merged

Conversation

Jennievon
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

https://github.com/ten-protocol/ten-internal/issues/3140
Add security headers as proposed by Beagle Security mitigation techniques

What changes were made as part of this PR

Please provide a high level list of the changes made

  • set X-Frame-Options to deny to prevent the page from being loaded in an iFrame
  • set X-Content-Type-Options to nosniff to indicate the browser shouldn't interpret the response as something other than the specified content type

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@Jennievon Jennievon requested a review from zkokelj March 20, 2024 12:30
Copy link
Contributor

@zkokelj zkokelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Maybe worth checking if we need to include also some other security related tags with this PR

@Jennievon Jennievon merged commit 93141c4 into releases/v0.23 Apr 3, 2024
1 check passed
@Jennievon Jennievon deleted the jennifer/3139-add-beagle-security-to-gateway branch April 3, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants