remove legacy signature type #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BedrockSquirrel
approved these changes
Mar 25, 2024
go/common/viewingkey/viewing_key.go
Outdated
| func GenerateViewingKeyForWallet(wal wallet.Wallet) (*ViewingKey, error) { | ||
| // generate an ECDSA key pair to encrypt sensitive communications with the obscuro enclave | ||
| vk, err := crypto.GenerateKey() | ||
| chainID := int64(443) |
There was a problem hiding this comment.
I think wallet has a chainID field on it, might be better to use that rather than hardcoding if poss. In case we end up with different chainIDs on diff Ten networks eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
I already removed old wallet extension endpoints from the gateway. Now we only use and produce new signatures (EIP712 and PersonalSign). There is no need to support old legacy format anymore and it just adds additional complexity to our codebase.
What changes were made as part of this PR
Removed old legacy format for signed viewing keys.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks