v0.23 release patch for rotating/trimming docker logs (#3116) #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he container is 30m.
…ding the base image and matching current deployments. delete current image step added.
|
@BedrockSquirrel same thing as the other, just against the release so it can be tagged to v0.23.3. This one we know doesn't have issues, but the PR against main can wait to be merged pending the other https://github.com/ten-protocol/ten-internal/issues/3156 - although unlikely there is any conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Containers (nodes) were crashing due to overflow of container logs (default is persisting internally to json-file) which had no rotation scheme.
This is a patch PR for inclusion to a v0.23.3 compared to #1850 which is against main.
What changes were made as part of this PR
Added some log options to the standard rolling behavior of 10m per log file -> creation of new file when exceeding -> maximum historic files of 3 -> delete oldest on next rotation.
This is a passive approach and won't affect relaying to datadog etc as it maintains the same default format on the log-type.
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks