Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tenscan] Add formatNumber utility function to display numbers with commas #1865

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

Jennievon
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

https://github.com/ten-protocol/ten-internal/issues/3196 - Format numbers with commas

What changes were made as part of this PR

Please provide a high level list of the changes made

  • Added a utility function to format numbers with commas
  • Used the utility function to format numbers in the UI

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@Jennievon Jennievon self-assigned this Apr 3, 2024
@CaisManai CaisManai self-requested a review April 19, 2024 15:02
Copy link
Contributor

@CaisManai CaisManai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jennievon Jennievon merged commit 3e566ff into main Apr 23, 2024
1 of 2 checks passed
@Jennievon Jennievon deleted the jennifer/3196-tenscan-numbers-formatting branch April 23, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants