Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing both tokens with 0x prefix and without it #1869

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Apr 3, 2024

Why this change is needed

This is a temporary fix that enables local testnet again.
In a separate PR I will provide full solution with consistent usage of 0x prefix and fixed gateway issues.

Local testnet was successfully started with this branch: https://github.com/ten-protocol/ten-test/actions/runs/8543430314/job/23407243846

What changes were made as part of this PR

accept both tokens with 0x prefix and without it.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@zkokelj zkokelj marked this pull request as ready for review April 3, 2024 18:39
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zkokelj zkokelj merged commit 8da215b into main Apr 4, 2024
2 checks passed
@zkokelj zkokelj deleted the ziga/fix_local_testnet_start branch April 4, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants