Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dcap url #1871

Merged
merged 1 commit into from
Apr 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions go/enclave/main/entry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,11 @@ if [ ! -L /dev/sgx/enclave ]; then
ln -s /dev/sgx_enclave /dev/sgx/enclave
fi

# If the PCCS_ADDR, the host is provided
# Do not use the default PCCS_URL defined in /etc/sgx_default_qcnl.conf
# Particularly used in Alibaba cloud
if [ -n "${PCCS_ADDR}" ]; then
PCCS_URL=https://${PCCS_ADDR}/sgx/certification/v3/
fi
PCCS_URL=https://global.acccache.azure.net/sgx/certification/v4/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes the support that Pedro put in for other cloud providers by hardcoding it to azure, that ok for now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok. We'll have to try again anyway

echo "PCCS_URL: ${PCCS_URL}"

# Install the libsgx-dcap-default-qpl and redefine /etc/sgx_default_qcnl.conf (Alibaba)
if [ -n "${PCCS_URL}" ]; then
apt-get install -qq libsgx-dcap-default-qpl
echo "PCCS_URL: ${PCCS_URL}"
echo "PCCS_URL=${PCCS_URL}\nUSE_SECURE_CERT=FALSE" > /etc/sgx_default_qcnl.conf
else
# Otherwise use the Azure library
apt-get install -qq az-dcap-client
fi
apt-get install -qq libsgx-dcap-default-qpl

echo "PCCS_URL=${PCCS_URL}\nUSE_SECURE_CERT=FALSE" > /etc/sgx_default_qcnl.conf

"$@"
Loading