-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tenscan APIs #1879
New Tenscan APIs #1879
Conversation
…ll/tenscan_api
…ll/tenscan_api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, Will.
LGTM (minor improvement suggested)
selectLatestRollup = "SELECT ext_rollup FROM rollup_host ORDER BY time_stamp DESC LIMIT 1" | ||
selectExtRollup = "SELECT ext_rollup from rollup_host r" | ||
selectLatestRollup = "SELECT ext_rollup FROM rollup_host ORDER BY time_stamp DESC LIMIT 1" | ||
selectRollupBatches = "SELECT b.sequence, b.hash, b.full_hash, b.height, b.ext_batch FROM rollup_host r JOIN batch_host b ON r.start_seq <= b.sequence AND r.end_seq >= b.sequence" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to order by b.height desc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, made the change. Cheers
Why this change is needed
Tenscan UI Improvements
API changes described here
What changes were made as part of this PR
/items/rollups/
/items/v2/batches/
/items/batches
in the same PR that has the new UI but just for backwards compatibility and testing both are here/items/rollup/:hash
/items/rollup/:hash/batches/
/items/batch/:fullHash/transactions/
/items/batch/height/:height
/items/rollup/batch/:seq
/items/transaction/:hash
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks