Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres connection pooling #1880

Closed
wants to merge 1 commit into from
Closed

Conversation

badgersrus
Copy link
Contributor

@badgersrus badgersrus commented Apr 17, 2024

Why this change is needed

Resolve this bug on dev

What changes were made as part of this PR

  • Add connection pooling to postgres.go
  • Duplicate the migration code due to trying to support the db *sql.DB as well through an interface results in needing to create a pgxpool.Pool wrapper and override the RowsAffected and LastInsertId methods

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@badgersrus
Copy link
Contributor Author

Closing as this can be fixed through azure infra using PgBouncer.

@badgersrus badgersrus closed this Apr 18, 2024
@badgersrus badgersrus deleted the will/connection-pool-fix branch April 30, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant