Pass Context from enclave rpc to database #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BedrockSquirrel
approved these changes
Apr 23, 2024
| @@ -67,11 +71,16 @@ func UnauthenticatedTenRPCCall[R any](ctx context.Context, w *Services, cfg *Cac | |||
| return withPlainRPCConnection(w, func(client *rpc.Client) (*R, error) { | |||
| var resp *R | |||
| var err error | |||
|
|
|||
| basectx := ctx | |||
There was a problem hiding this comment.
Maybe we could just return an error if context is nil (if there's no way to enforce not nil). I had a quick glance and it seems like all usages pass in a context.
There was a problem hiding this comment.
good idea. simplifies it
StefanIliev545
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Some SQL calls are very slow, and we need a way to cancel them.
The "Ten Gateway" makes all RPC calls to the node with a hardcoded Timeout Context of 5s. This context is propagated through the host to the enclave, and all the way to the database calls.
Note that the EVM db calls are happening outside the context. For those, we use a configuration.
What changes were made as part of this PR
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks