Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade geth #1883

Merged
merged 7 commits into from
Apr 26, 2024
Merged

Upgrade geth #1883

merged 7 commits into from
Apr 26, 2024

Conversation

tudor-malene
Copy link
Collaborator

@tudor-malene tudor-malene commented Apr 24, 2024

Why this change is needed

We need to use the latest version of go-ethereum to benefit from the latest performance and security fixes.

What changes were made as part of this PR

  1. The most important change is switching the logging engine. To replicate our existing behaviour, we have to tweak the terminal handler, which required duplicating some code. We'll remove that soon, once we transition to json logging.
  2. go-ethereum no longer uses big.Int for balances, and also requires a tracing hint when changing native balances
  3. The ApplyMessage function is no longer internal
  4. The Block type needs to be passed by reference because it contains locks

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@tudor-malene tudor-malene changed the title WIP upgrade geth Upgrade geth Apr 25, 2024
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/faucet/faucet/faucet.go Outdated Show resolved Hide resolved
@tudor-malene tudor-malene merged commit 49112a3 into main Apr 26, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/upgrade_eth branch April 26, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants