Host: replace sequencer ID config with sequencer p2p address #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BedrockSquirrel
force-pushed
the
matt/seq-address-from-config
branch
from
02f65e5 to
8766344
Compare
BedrockSquirrel
commented
Apr 29, 2024
| attestedKey *ecdsa.PublicKey | ||
| storage storage.Storage | ||
| } | ||
|
|
||
| func NewSignatureValidator(seqID gethcommon.Address, storage storage.Storage) (*SignatureValidator, error) { | ||
| func NewSignatureValidator(storage storage.Storage) (*SignatureValidator, error) { |
There was a problem hiding this comment.
This obviously v dodgy atm. Working on PR to validate the sigs against the sequencer enclave ID(s) from management contract.
| @@ -370,6 +354,15 @@ func (p *Service) handle(conn net.Conn) { | |||
| } | |||
| // this is an incoming request, p2p service is responsible for finding the response and returning it | |||
| go p.handleBatchRequest(msg.Contents) | |||
| case msgTypeRegisterForBroadcasts: | |||
There was a problem hiding this comment.
is there a mechanism to clean up the peers, in case they drop off the network?
Also, what about restarts and persistence?
There was a problem hiding this comment.
No persistence, I've tried to keep it quite tolerant to validators coming and going with these rules:
- if broadcast to a validator fails 3 times then the validator is removed from the pool (this cleans up validators that drop off)
- if validator doesn't receive a broadcast in a 2min period it requests to the sequencer to add it back to the pool (this would account for the sequencer getting restarted, the validators would re-register)
There was a problem hiding this comment.
Sounds good. But this mechanism should be highlighted or commented on in the code.
This behaviour was not obvious to me at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
We are removing the host p2p addresses from management contract, instead validators must be provided with the sequencer p2p address.
Also they no longer need sequencer ID in config since they will use the management contract as the source of truth for what enclave IDs are allowed to produce batches.
What changes were made as part of this PR
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks