Move public tx listing API to host DB query #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badgersrus
requested review from
tudor-malene and
BedrockSquirrel
and removed request for
tudor-malene
| "fmt" | ||
| "math/big" | ||
|
|
||
| common2 "github.com/ethereum/go-ethereum/common" |
There was a problem hiding this comment.
Something's gone awry here, this looks the same as the gethcommon import below (which is the naming convention we've been using, Goland autogenerates common2 sometimes).
There was a problem hiding this comment.
Kinda crappy that the linter doesn't pick this up...
| query := selectTxs + db.GetSQLStatement().Pagination | ||
| rows, err := db.GetSQLDB().Query(query, pagination.Size, pagination.Offset) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
It's a pain in the ass but good practice to wrap all these errors with a short description, because it makes it easier to figure out what step an error came from when debugging.
e.g. return nil, fmt.Errorf("unable to execute query - %w", err)
There's a couple more of these return errs below so be good to remove the ambiguity with them too 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
We currently query this from the enclave client but its producing some strange pagination errors and we don't need to access the enclave for this data now we have it in the host DB.
https://github.com/ten-protocol/ten-internal/issues/3324
What changes were made as part of this PR
FetchTransactionsAPI to the host DBEnclaveClientto the new host interface methodtransactions_host>transaction_hostto match naming conventionEnclaveClientAPIPR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks