Host: notify separately for new heads and new validated heads #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BedrockSquirrel
force-pushed
the
matt/new-heads-after-enclave-process
branch
from
ccd026b to
aaf2074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
We have bugs that are likely caused by the host newHeads subscriptions getting notified of new batches before the enclave has processed them.
What changes were made as part of this PR
Separate out the L2 repo's subscribers between those that want to know about a new head added to the DB and a new head batch that has been validated by that node's own enclave. Use the latter for the new heads RPC subscriptions.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks