Wire edgeless in simulation mode for local testnet #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-malene
commented
May 9, 2024
| } | ||
|
|
||
| // only set the pccsAddr env var if it's defined | ||
| if d.cfg.pccsAddr != "" { | ||
| envs["PCCS_ADDR"] = d.cfg.pccsAddr | ||
| } | ||
|
|
||
| // todo - do we need this volume? |
There was a problem hiding this comment.
@BedrockSquirrel , can you think of any situation where we need the data between different runs of the testnet?
(Other than upgrades, which we don't test locally currently?)
There was a problem hiding this comment.
I'm a bit confused, yeah it's just for upgrades. But doesn't this code gets used for the main testnets as well as the local testnets?
There was a problem hiding this comment.
Worth deleting this then, or want to leave it in case we need to add it back in?
There was a problem hiding this comment.
yeah. there might be scenarios we don't know
BedrockSquirrel
approved these changes
May 9, 2024
| } | ||
|
|
||
| // only set the pccsAddr env var if it's defined | ||
| if d.cfg.pccsAddr != "" { | ||
| envs["PCCS_ADDR"] = d.cfg.pccsAddr | ||
| } | ||
|
|
||
| // todo - do we need this volume? |
There was a problem hiding this comment.
Worth deleting this then, or want to leave it in case we need to add it back in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Sqlite doesn't work properly under load. The e2e tests running against a "local testnet" deployment fail with "database locked"
What changes were made as part of this PR
replace sqlite with edgeless for the "local testnet"
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks