Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TX count API #1906

Merged
merged 4 commits into from
May 15, 2024
Merged

Expose TX count API #1906

merged 4 commits into from
May 15, 2024

Conversation

badgersrus
Copy link
Contributor

@badgersrus badgersrus commented May 9, 2024

Why this change is needed

Realised during testing it was missing

What changes were made as part of this PR

  • Add new /items/transactions/count path to get the tx count needed on tenscan
  • Group the endpoints so its easier to read
  • Add function names to errors for easier debugging

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@badgersrus badgersrus merged commit 218f40b into main May 15, 2024
2 checks passed
@badgersrus badgersrus deleted the will/pagination branch May 15, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants