Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network tests: new heads subscriptions #1907

Merged
merged 2 commits into from
May 10, 2024

Conversation

BedrockSquirrel
Copy link
Collaborator

Why this change is needed

Wanted to be able to monitor new heads subscriptions from network tests.

What changes were made as part of this PR

Added an action and a basic test for starting a network heads subscription against the gateway. Had to add support for gateway WS client to the network tests to allow this.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one.
lgtm!

@BedrockSquirrel BedrockSquirrel merged commit 6c12e16 into main May 10, 2024
2 checks passed
@BedrockSquirrel BedrockSquirrel deleted the matt/new-heads-investigation branch May 10, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants