Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve log subscription unsubscribe #1915

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

tudor-malene
Copy link
Collaborator

@tudor-malene tudor-malene commented May 15, 2024

Why this change is needed

the log subscription unsubscribe process is not working properly

What changes were made as part of this PR

  • change the order of actions
  • reduce lock contention
  • make some logs less noisy

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tudor-malene tudor-malene merged commit 1acc9e3 into main May 15, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/fix_logs_unsub branch May 15, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants