Deploy Ten Gateway as an application running inside SGX container #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anixon604
requested changes
May 20, 2024
| steps: | ||
| - name: 'Print GitHub variables' | ||
| if: matrix.testnet_type == github.event.inputs.testnet_type |
There was a problem hiding this comment.
You should be able to reduce the matrix condition checks by having a top level step - cause each matrix will iterate overall the steps then to the next matrix:
- name: 'Check if selected testnet matches matrix testnet'
if: matrix.testnet_type != github.event.inputs.testnet_type
run: exit 0
There was a problem hiding this comment.
nice one, thanks 🙏
fixed
| @@ -0,0 +1,39 @@ | |||
| -----BEGIN RSA PRIVATE KEY----- | |||
There was a problem hiding this comment.
Is it possible that we put this in a gh secret and then pull it out, https://tinyurl.com/yc78scsm
There was a problem hiding this comment.
added that, but I think we will need to change it also for L2 deployment. The same testnet.pem file is also there.
|
split it into multiple smaller PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Please provide a description and a link to the underlying ticket
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks