Fix for interval. #1926
Merged
Fix for interval. #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
description pls |
tudor-malene
requested changes
May 21, 2024
go/host/enclave/guardian.go
Outdated
| if interval == 0 { | ||
| interval = g.blockTime | ||
| interval = 20 * time.Second |
There was a problem hiding this comment.
shouldn't this be a default somewhere?
And the log does not match the value
go/host/enclave/guardian.go
Outdated
| g.logger.Debug("No cross chain data to submit. Skipping.") | ||
| continue | ||
| } | ||
|
|
||
| err = g.sl.L1Publisher().PublishCrossChainBundle(bundle) |
There was a problem hiding this comment.
does this mean you're publishing even if there is nothing to publish?
There was a problem hiding this comment.
Yep, it's less than ideal
| @@ -286,10 +286,6 @@ func (p *Publisher) PublishCrossChainBundle(bundle *common.ExtCrossChainBundle) | |||
| return nil | |||
| } | |||
|
|
|||
| if len(bundle.CrossChainRootHashes) == 0 { | |||
There was a problem hiding this comment.
am I missing something, or will this keep publishing every time?
There was a problem hiding this comment.
the guardian loop continues before calling this when empty
StefanIliev545
added a commit
that referenced
this pull request
May 22, 2024
* Fix for interval. * Removed defaulting from guardian as there should already be a default value. * Made the fromSeqNo to be local. * Modify how the local cached seq no is set. * Add missing cfg option. * Another missing default value. --------- Co-authored-by: StefanIliev545 <[email protected]>
StefanIliev545
added a commit
that referenced
this pull request
May 22, 2024
* Fix for interval. * Removed defaulting from guardian as there should already be a default value. * Made the fromSeqNo to be local. * Modify how the local cached seq no is set. * Add missing cfg option. * Another missing default value. --------- Co-authored-by: StefanIliev545 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Please provide a description and a link to the underlying ticket
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks