-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade local Geth version to PoS #1950
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ll/upgrade-geth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , if it works (including local testnet)
I left a few minor comments.
Also, we should try to keep big refactoring (renaming) PRs separate from functionality PRs, as it makes it a bit harder to review.
"strconv" | ||
) | ||
|
||
func getBuildNumber() (int, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function could use a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ( once the "local tests" are confirmed)
Why this change is needed
EIP-4844 support
What changes were made as part of this PR
Obscuro
toTen
in files I came across (sorry, but needs doing eventually!)PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks