Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade local Geth version to PoS #1950

Merged
merged 111 commits into from
Aug 8, 2024
Merged

Upgrade local Geth version to PoS #1950

merged 111 commits into from
Aug 8, 2024

Conversation

badgersrus
Copy link
Contributor

@badgersrus badgersrus commented Jun 5, 2024

Why this change is needed

EIP-4844 support

What changes were made as part of this PR

  • Upgrade geth version to 1.14.6
  • Upgrade prysm version to 5.0.4
  • Move to a new script based network generation
  • Add clunky build number sequence due to issues with the geth.ipc path when running on github, unix char limit (parallelisation of tests mean you need each one in its on directory for the beacon chain to execute against)
  • Move to singular geth/ beacon nodes. Can run multiple validator clients easily
  • Increased PR build timeout to 10m for the full sim test which takes ~ 9mins now
  • Refactored all instances of Obscuro to Ten in files I came across (sorry, but needs doing eventually!)

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridge ❌ Failed (Inspect) Jun 5, 2024 4:19pm

@badgersrus badgersrus requested a review from tudor-malene July 24, 2024 10:53
Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , if it works (including local testnet)

I left a few minor comments.
Also, we should try to keep big refactoring (renaming) PRs separate from functionality PRs, as it makes it a bit harder to review.

"strconv"
)

func getBuildNumber() (int, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function could use a comment

testnet/launcher/l1contractdeployer/docker.go Outdated Show resolved Hide resolved
@badgersrus badgersrus requested a review from tudor-malene July 29, 2024 14:52
Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ( once the "local tests" are confirmed)

@badgersrus badgersrus merged commit 3846fa5 into main Aug 8, 2024
3 checks passed
@badgersrus badgersrus deleted the will/upgrade-geth branch August 8, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants