Fixes for ethereum bridge and json representation of batch header. #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 3, 2024 19:00
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added 2 commits
June 6, 2024 10:30
tudor-malene
approved these changes
Jun 6, 2024
| if err != nil { | ||
| if !errors.Is(err, errutil.ErrCrossChainBundleNoBatches) { | ||
| g.logger.Error("Unable to export cross chain bundle from enclave", log.ErrKey, err) | ||
| } | ||
| if errors.Is(err, context.DeadlineExceeded) { |
There was a problem hiding this comment.
so this is the fix for the load issue?
There was a problem hiding this comment.
No, this is just a patch to shutdown bundle exports on UAT and Dev testnet if we ever hit it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
The EthereumBridge needs to call the message bus in order to send the value over to the layer 1.
The header now encodes a cross chain tree root hash in the json serialisation exposed through the external rpc
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks