Adds log constraints to docker containers not instantiated by the go client #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkokelj
reviewed
Jun 10, 2024
| @@ -130,10 +130,12 @@ jobs: | |||
| -v /proc/:/host/proc/:ro \ | |||
| -v /opt/datadog-agent/run:/opt/datadog-agent/run:rw \ | |||
| -v /sys/fs/cgroup/:/host/sys/fs/cgroup:ro \ | |||
| --log-opt max-file=3 --log-opt max-size=10m \ | |||
There was a problem hiding this comment.
what happens when we reach the limit? do we truncate the file?
why is it set to only 10 MB?
There was a problem hiding this comment.
it's just a rotating log file - will delete the oldest - so the total logs available will be the last 3*10MB (30mb). It's just what seemed useful originally as a set-point based on how we were using. we can definitely swap the params to different values though... @zkokelj
zkokelj
reviewed
Jun 10, 2024
| @@ -102,6 +102,7 @@ jobs: | |||
| -v /proc/:/host/proc/:ro \ | |||
| -v /opt/datadog-agent/run:/opt/datadog-agent/run:rw \ | |||
| -v /sys/fs/cgroup/:/host/sys/fs/cgroup:ro \ | |||
| --log-opt max-file=3 --log-opt max-size=10m \ | |||
There was a problem hiding this comment.
I think it's not needed here. We have local logs only for gateway and not for gateway databse.
There was a problem hiding this comment.
Yes, but i think it's still okay to leave here. The reason is that the agent itself is emitting logs - although at a much lower rate. But if it was up a super long time, then it could potentially fill up the container fs...
2024-06-10 18:12:27 UTC | TRACE | INFO | (pkg/trace/info/stats.go:91 in LogAndResetStats) | No data received
2024-06-10 18:12:52 UTC | CORE | INFO | (pkg/serializer/serializer.go:454 in SendProcessesMetadata) | Sent processes metadata payload, size: 1415 bytes.
2024-06-10 18:13:27 UTC | TRACE | INFO | (pkg/trace/info/stats.go:91 in LogAndResetStats) | No data received
2024-06-10 18:14:22 UTC | PROCESS | INFO | (pkg/process/runner/runner.go:247 in logCheckDuration) | Finish container check #640 in 3.485494ms
2024-06-10 18:14:27 UTC | TRACE | INFO | (pkg/trace/info/stats.go:91 in LogAndResetStats) | No data received
2024-06-10 18:15:32 UTC | TRACE | INFO | (pkg/trace/info/stats.go:91 in LogAndResetStats) | No data received
2024-06-10 18:16:32 UTC | TRACE | INFO | (pkg/trace/info/stats.go:91 in LogAndResetStats) | No data received
2024-06-10 18:17:37 UTC | TRACE | INFO | (pkg/trace/info/stats.go:91 in LogAndResetStats) | No data received
2024-06-10 18:17:42 UTC | PROCESS | INFO | (pkg/process/runner/runner.go:247 in logCheckDuration) | Finish container check #660 in 3.250694ms
2024-06-10 18:17:52 UTC | CORE | INFO | (pkg/serializer/serializer.go:454 in SendProcessesMetadata) | Sent processes metadata payload, size: 1422 bytes.
2024-06-10 18:18:42 UTC | TRACE | INFO | (pkg/trace/info/stats.go:91 in LogAndResetStats) | No data received
2024-06-10 18:18:50 UTC | CORE | INFO | (pkg/serializer/serializer.go:429 in sendMetadata) | Sent metadata payload, size (raw/compressed): 1080/432 bytes.
2024-06-10 18:18:51 UTC | CORE | INFO | (pkg/serializer/serializer.go:429 in sendMetadata) | Sent metadata payload, size (raw/compressed): 34320/8352 bytes.
2024-06-10 18:18:51 UTC | CORE | INFO | (pkg/serializer/serializer.go:429 in sendMetadata) | Sent metadata payload, size (raw/compressed): 1978/492 bytes.
2024-06-10 18:18:52 UTC | CORE | INFO | (pkg/util/cloudproviders/cloudproviders.go:52 in DetectCloudProvider) | Cloud provider Azure detected
2024-06-10 18:18:52 UTC | CORE | INFO | (pkg/util/cloudproviders/cloudproviders.go:60 in DetectCloudProvider) | Detecting cloud provider account ID from Azure: "6e522d3f-f104-4fdf-bf88-76d2fe400cca"
2024-06-10 18:18:52 UTC | CORE | INFO | (pkg/serializer/serializer.go:429 in sendMetadata) | Sent metadata payload, size (raw/compressed): 1103/635 bytes.
2024-06-10 18:19:47 UTC | TRACE | INFO | (pkg/trace/info/stats.go:91 in LogAndResetStats) | No data received
2024-06-10 18:20:47 UTC | TRACE | INFO | (pkg/trace/info/stats.go:91 in LogAndResetStats) | No data received
2024-06-10 18:21:02 UTC | PROCESS | INFO | (pkg/process/runner/runner.go:247 in logCheckDuration) | Finish container check #680 in 3.526283ms
2024-06-10 18:21:52 UTC | TRACE | INFO | (pkg/trace/info/stats.go:91 in LogAndResetStats) | No data received
|
I think the tests were failing but it's unrelated. |
zkokelj
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Containers for gateway are instantiated manually via docker run which isn't applying the
max-fileandmax-loglogging options to the containers.What changes were made as part of this PR
Added the logging options to the execution statements in the workflows.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks