[gateway] assets fix and clear console warnings #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Jennievon
changed the title
zkokelj
requested changes
Jun 11, 2024
| @@ -25,9 +25,9 @@ const HeadSeo = ({ | |||
| signature="_vd3udx2g2hfn9zclob5cat43b94q7fyk" | |||
| ></meta> | |||
| {/* SECURITY: to prevent the page from being loaded in an iFrame */} | |||
| <meta http-equiv="X-Frame-Options" content="deny"></meta> | |||
| <meta httpEquiv="X-Frame-Options" content="deny"></meta> | |||
There was a problem hiding this comment.
I stil get those errors in console.
| @@ -14,7 +14,7 @@ export default function Header() { | |||
| <div className="flex h-16 justify-between items-center px-4"> | |||
| <Link href="/"> | |||
| <Image | |||
| src="/static/assets/images/black_logotype.png" | |||
| src="/assets/images/black_logotype.png" | |||
There was a problem hiding this comment.
logos are now broken in both white and black version.
I run: npm run build and then serve static files with golang (same way as then deployed to Azure).
…nnifer/1958-gateway-assets-fix
Jennievon
force-pushed
the
jennifer/1958-gateway-assets-fix
branch
from
2ab57c3 to
d747d6b
Compare
zkokelj
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Please provide a description and a link to the underlying ticket
#1958
What changes were made as part of this PR
Please provide a high level list of the changes made
http-equivtohttpEquivas React recognises the former as anInvalid DOM propertyWarning: React does not recognize thefetchPriorityprop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercasefetchpriorityinstead.this occured because there was a bug in the next package version and the bug has been fixed but we needed to update the package version too
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks