Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overshoot balance fix on estimate gas. #1970

Merged

Conversation

StefanIliev545
Copy link
Contributor

Why this change is needed

Please provide a description and a link to the underlying ticket

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -626,55 +625,6 @@ func (g *Guardian) periodicRollupProduction() {
}
}

func (g *Guardian) periodicBundleSubmission() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to remove this?
Shouldn't matter, but it might cause issues when cherry-picking to main

@StefanIliev545 StefanIliev545 merged commit 7c6c429 into releases/v0.24 Jun 26, 2024
1 check passed
@StefanIliev545 StefanIliev545 deleted the siliev/v0.24/gas-estimation-overshoot-fix branch June 26, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants