Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split up storage and improve caching #1977

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

The "Storage" file has accumulated too many responsibilities.
The caching mechanism is not fine-grained enough when it comes to memory.

What changes were made as part of this PR

  • split up a caching service, and add an approximate cost
  • split up an event storage service

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tudor-malene tudor-malene merged commit f396ac6 into main Jul 3, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/clean_up_storage branch July 3, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants