Deployment scripts rework to work locally. #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 30, 2024 17:40
| } | ||
|
|
||
| func (api *NetAPI) Config(ctx context.Context) (*ConfigResponseJson, error) { | ||
| return UnauthenticatedTenRPCCall[ConfigResponseJson](ctx, api.we, &CacheCfg{CacheType: LongLiving}, "obscuro_config") |
There was a problem hiding this comment.
Isn't this called ten_config now?
returning a TenNetworkInfo object
You can try this out in the gateway test
There was a problem hiding this comment.
I just added this, the net_ namespace seemed most appropriate. It doesn't seem we currently have a ten one yet. Should I create one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Deployment scripts are setup in a way that requires them to run in a docker container, launched from the hardhat launcher go file and wired with some specific env variables. This PR will change this.
What changes were made as part of this PR
Instead of only using the ENV variables, whenever they are NOT declared, the deployment scripts will poll the provider for the
net_configendpoint, which in turn goes toobscuro_configunder the gateway and returns the contract addresses that matter - Management, L1 Bus, L2 Bus. This way the deployment can figure out its dependencies from the network and continue forth. This allows the local deployments to work.PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks