filter out irrelevant l1 txs, before sending into the enclave #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-malene
commented
Aug 5, 2024
| @@ -425,6 +425,15 @@ func (g *Guardian) submitL1Block(block *common.L1Block, isLatest bool) (bool, er | |||
| g.submitDataLock.Unlock() // lock must be released before returning | |||
| return false, fmt.Errorf("could not fetch obscuro receipts for block=%s - %w", block.Hash(), err) | |||
| } | |||
| // only submit the relevant transactions to the enclave | |||
There was a problem hiding this comment.
this is the only material change in this pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
We have a memory leak which kills our node every few days on sepolia.
Upon investigation, it turns out there is a memory leak inside RLP decoding when submitting a sepolia block. More specifically when decoding the L1 transactions.
We only need very few L1 transactions inside the enclave, and we are sending all of them.
What changes were made as part of this PR
Filter out transactions that are irrelevant before submitting an L1 block to the enclave.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks