improve deadline error #2015
Merged
improve deadline error #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BedrockSquirrel
approved these changes
Aug 13, 2024
| @@ -52,6 +54,7 @@ type ExecCfg struct { | |||
| tryUntilAuthorised bool | |||
| adjustArgs func(acct *GWAccount) []any | |||
| cacheCfg *CacheCfg | |||
| deadline time.Duration | |||
There was a problem hiding this comment.
Nitpick I'd probably call it timeout rather than deadline
moraygrieve
reviewed
Aug 13, 2024
| @@ -34,13 +34,15 @@ const ( | |||
| ethCallAddrPadding = "000000000000000000000000" | |||
|
|
|||
| notAuthorised = "not authorised" | |||
| serverBusy = "server busy. please retry later" | |||
There was a problem hiding this comment.
should it say retry? i.e. the transaction might have actually gone through, so you wouldn't want to send again, just go into reconcilliation
There was a problem hiding this comment.
the error response is generic for all rpc calls. The tx submission has a much higher timeout, so it shouldn't really be shown there, unless there is something really wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed