Add network config endpoint #2016
Conversation
| } | ||
|
|
||
| // Define a struct to represent the response | ||
| type NetworkConfigResponse struct { |
There was a problem hiding this comment.
Bit of a shame that we can't use ObscuroNetworkInfo like the ObsClient but I guess it's for json compatibility? Maybe better to have separate control over it anyway.
There was a problem hiding this comment.
Yeah, it is because of that + we need to convert data fields to strings. I was also asking ChatGPT if there is a good way, but unfortunately nothing simpler than that :/
| @@ -283,6 +283,14 @@ func (w *Services) GetTenNodeHealthStatus() (bool, error) { | |||
| return *res, err | |||
| } | |||
|
|
|||
| func (w *Services) GetTenNetworkConfig() (tencommon.TenNetworkInfo, error) { | |||
| res, err := withPlainRPCConnection[tencommon.TenNetworkInfo](context.Background(), w, func(client *gethrpc.Client) (*tencommon.TenNetworkInfo, error) { | |||
There was a problem hiding this comment.
Does this do any caching by default? Maybe safer not to cache for now I guess, there are some edge cases when network starts up before L2 contract deployment maybe.
There was a problem hiding this comment.
No, it doesn't do any caching. I was thinking about it, but it's not an expensive call to the node and we can add it later if needed.
Why this change is needed
We need gateway endpoint for getting network config:
Ticket
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks