Separate deployment of Gateway frontend and backend #2032
Conversation
zkokelj
changed the title
| @@ -139,6 +139,6 @@ jobs: | |||
| -e OBSCURO_GATEWAY_VERSION="${{ GITHUB.RUN_NUMBER }}-${{ GITHUB.SHA }}" \ | |||
| --log-opt max-file=3 --log-opt max-size=10m \ | |||
| ${{ vars.DOCKER_BUILD_TAG_GATEWAY }} \ | |||
| -host=0.0.0.0 -port=8080 -portWS=81 -nodeHost=${{ vars.L2_RPC_URL_VALIDATOR }} -verbose=true \ | |||
There was a problem hiding this comment.
can we stick to the usual FE convention of 3000 for the FE?
There was a problem hiding this comment.
this workflow is for the backend gateway (API)
| steps: | ||
| - name: 'Print GitHub variables' | ||
| run: | | ||
| echo "Selected Testnet Type: ${{ matrix.testnet_type }}" | ||
| echo "Gateway API URL: ${{ matrix.GATEWAY_API_URL }}" | ||
| echo "Gateway API URL: ${{ vars.GATEWAY_URL }}" |
There was a problem hiding this comment.
how is this differentiated for each env?
There was a problem hiding this comment.
we have separate environments (https://github.com/ten-protocol/go-ten/settings/environments ) and for each environment we need GATEWAY_URL variable which represents the URL for that specific testnet type.
tools/walletextension/README.md
Outdated
| To build a docker image use docker build command. Please note that you need to run it from the root of the repository. | ||
| To run the container you can use `./docker_run.sh`. You can add parameters to the script, and they are passed to the wallet extension | ||
| (example: `-host=0.0.0.0` to be able to access wallet extension endpoints via localhost). | ||
| The frontend will be accessible on `http://localhost:80`. |
There was a problem hiding this comment.
this would need to be updated as well if you're happy to switch to 3000
There was a problem hiding this comment.
the problem is that gateway backend also runs on port 3000 (by default).
If you think it would be better I can switch to a different port for the backend and leave frontend one on port 3000.
| @@ -3,7 +3,7 @@ | |||
| "version": "0.1.0", | |||
| "private": true, | |||
| "scripts": { | |||
| "dev": "next dev", | |||
| "dev": "next dev -p 80", | |||
Why this change is needed
In this PR I separated the deployment of gateway frontend and backend.
This is necessary for:
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks