Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the body of the l1 blocks from the payload sent into the enclave. #2046

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

  • There is a memory leak somewhere in the RLP code.
  • The enclave doesn't need the body of the L1 blocks because it doesn't execute those transactions.

What changes were made as part of this PR

  • only send the block header and the ten-specific transactions
  • change a lot of method signatures to use types.Header instead of types.Block, plus a few changes to get the height or the hash
  • duplicate some logic to be used for the mock ethereum nodes which use blocks

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tudor-malene tudor-malene merged commit a40b73b into main Sep 5, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/remove_l1_block_body_from_enclave branch September 5, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants