improve visibility config #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bool topic2CanView; // same | ||
| bool topic3CanView; // same | ||
| bool visibleToSender; // if true, the tx signer will see this event. Default false | ||
| uint256 eventSignature; |
There was a problem hiding this comment.
oops. good spot
go/enclave/evm/evm_facade.go
Outdated
| t2 := relevantToMap[topic2] | ||
| t3 := relevantToMap[topic3] | ||
| s := relevantToMap[sender] | ||
| cfg.EventConfigs[logConfig.EventSignature] = &core.EventVisibilityConfig{ |
There was a problem hiding this comment.
Those really need a comment with examples to better understand event visibility.
There was a problem hiding this comment.
the comments are in the config. This is the implementation.
Aren't the comments in ContractTransparencyConfig.solenough?
| // erc20 transfer | ||
| configs[0] = EventLogConfig(hex"ddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef", false, true, true, false, false); | ||
| return VisibilityConfig(false, configs); | ||
| bytes32 eventSig = hex"ddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef"; |
There was a problem hiding this comment.
What is this hash from?
you can do "var visibilityRulesEventSignature = keccak256("preimage")"
StefanIliev545
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
To improve the developer experience when configuring the visibility rules
What changes were made as part of this PR
Add syntactic sugar to the configuration
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks