Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] update workflow and package mgr for monorepo config #2069

Merged

Conversation

Jennievon
Copy link
Contributor

@Jennievon Jennievon commented Sep 30, 2024

Why this change is needed

This PR migrates the frontend applications from npm to pnpm to improve package management and test the monorepo configuration setup. The updates include:

  • Switching from npm to pnpm for package management, optimising install speed and disk space usage
  • Adjusting the CI/CD workflow to reflect this package manager change

The migration to pnpm helps achieve better performance with workspace features and provides a way to adequately test the monorepo configuration setup for Tenscan, Gateway, and the Bridge visually before merging. Also, the monorepo structure will facilitate better collab and more efficient dependency mgt across the codebase

Issue: #3948

What changes were made as part of this PR

  • updated package.json scripts to use pnpm.
  • updated frontend workflows and Dockerfile to align with the new package manager.
  • configured workspace settings for monorepo support.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required PR checks:

  • PR checks reviewed and performed

@Jennievon Jennievon self-assigned this Sep 30, 2024
@Jennievon Jennievon force-pushed the jennifer/3948-create-workflow-to-test-monorepo-changes branch from 316a036 to 092b2b3 Compare September 30, 2024 18:56
@Jennievon Jennievon changed the title update package manager from npm to pnpm update package manager for monorepo config Sep 30, 2024
@Jennievon Jennievon changed the title update package manager for monorepo config [Frontend] update workflow and package mgr for monorepo config Sep 30, 2024
@Jennievon Jennievon requested review from zkokelj, BedrockSquirrel and pbienek and removed request for zkokelj September 30, 2024 19:15
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - might be good to try deploying in dev from this branch before merging though just to make sure we don't break deployments from main

@Jennievon
Copy link
Contributor Author

This PR removes npm support and fully migrates to pnpm. The current Dockerfile only supports npm, so it will need updating for pnpm compatibility before testing deployment in dev. I will need to merge this in and then test the monorepo config on dev.

@Jennievon Jennievon merged commit e86c051 into main Oct 1, 2024
2 of 4 checks passed
@Jennievon Jennievon deleted the jennifer/3948-create-workflow-to-test-monorepo-changes branch October 1, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants