[TenZen] System contracts deployment flow. #2079
Conversation
|
Description please. |
|
|
||
|
|
||
|
|
||
| library Structs { |
| import "./OnBlockEndCallback.sol"; | ||
| import "./Transaction.sol"; | ||
|
|
||
| //TODO: @PR Review - Pick appropriate name |
There was a problem hiding this comment.
Needs a comment.
I guess, this is the system contract that will dispatch the txs to the callbacks?
What about PostExecutionProcessor ?
There was a problem hiding this comment.
I'd say rename before merging
| return nil, fmt.Errorf("could not process on block end transaction hook. Cause: %w", err) | ||
| } | ||
| if err = executor.verifySyntheticTransactionsSuccess(onBlockPricedTxes, onBlockSuccessfulTx, onBlockTxResult); err != nil { | ||
| // todo: remove once feature finished |
There was a problem hiding this comment.
not sure what this is about
| } | ||
|
|
||
| s.logger.Debug("CreateOnBatchEndTransaction: Signing transaction", "to", s.transactionsAnalyzerAddress.Hex(), "nonce", nonceForSyntheticTx) | ||
| signedTx, err := s.ownerWallet.SignTransaction(tx) |
There was a problem hiding this comment.
being a synthetic tx, does it need to be signed?
If not, you wouldn't neet to pass that wallet
There was a problem hiding this comment.
I need to check on that, don't remember how the evm facade was doing things behind the scenes.
reminder |
| @@ -47,6 +48,42 @@ type BatchHeader struct { | |||
| CrossChainTree SerializedCrossChainTree `json:"crossChainTree"` // Those are the leafs of the merkle tree hashed for privacy. Necessary for clients to be able to build proofs as they have no access to all transactions in a batch or their receipts. | |||
| } | |||
|
|
|||
| func ConvertBatchHeaderToHeader(batchHeader *BatchHeader) *types.Header { | |||
There was a problem hiding this comment.
it needs to be a service because it needs access to the secret entropy to calculate the randomness per tx.
contracts/src/system/Transaction.sol
Outdated
| uint256 value; | ||
| bytes data; | ||
| address from; | ||
| bool successful; |
There was a problem hiding this comment.
I think it needs more fields from the receipt. Like how much gas it used. It might be useful
| import "./OnBlockEndCallback.sol"; | ||
| import "./Transaction.sol"; | ||
|
|
||
| //TODO: @PR Review - Pick appropriate name |
There was a problem hiding this comment.
I'd say rename before merging
| @@ -47,6 +48,42 @@ type BatchHeader struct { | |||
| CrossChainTree SerializedCrossChainTree `json:"crossChainTree"` // Those are the leafs of the merkle tree hashed for privacy. Necessary for clients to be able to build proofs as they have no access to all transactions in a batch or their receipts. | |||
| } | |||
|
|
|||
| func ConvertBatchHeaderToHeader(batchHeader *BatchHeader) *types.Header { | |||
There was a problem hiding this comment.
I realised what the problem is. We don't expose the converted ethereum headers and that's why all this conversion.
We even expose them in the gateway and there is nothing to back it up.
Pls raise a ticket to do this properly, and add a todo here
Why this change is needed
Please provide a description and a link to the underlying ticket
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks