Fix gas estimation for reverts that are considered consensus errors #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If the error is not nil(consensus error), it means the provided message | ||
| // call or transaction will never be accepted no matter how much gas it is | ||
| // assigned. Return the error directly, don't struggle any more. | ||
| if err != nil { | ||
| /*if err != nil && isFailedAtMax { |
There was a problem hiding this comment.
is this comment on purpose?
There was a problem hiding this comment.
yes, i decided to remove this altogether. Left it for clarity, as it's just a workaround. This whole bit of code was copy pasted ages ago, and I dont think it plays well with our codebase, but for the time being this should do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Gas estimation which we copied from geth fails when there is a revert while searching for proper gas. This is due to the error not being the correct gas too low (for whatever reason). This is a workaround.
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks