Use cosmosDB in the gateway and encrypt data with encryption key generated inside the enclave #2104
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,14 @@ | ||
| package common | ||
|
|
||
| type GWUserDB struct { | ||
| ID string `json:"id"` // Required by CosmosDB | ||
| UserId []byte `json:"userId"` | ||
| PrivateKey []byte `json:"privateKey"` | ||
| Accounts []GWAccountDB `json:"accounts"` // List of Accounts | ||
| } | ||
|
|
||
| type GWAccountDB struct { | ||
| AccountAddress []byte `json:"accountAddress"` | ||
| Signature []byte `json:"signature"` | ||
| SignatureType int `json:"signatureType"` | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| package encryption | ||
|
|
||
| import ( | ||
| "crypto/aes" | ||
| "crypto/cipher" | ||
| "crypto/hmac" | ||
| "crypto/rand" | ||
| "crypto/sha256" | ||
| "errors" | ||
| "fmt" | ||
| "io" | ||
| ) | ||
|
|
||
| type Encryptor struct { | ||
|
There was a problem hiding this comment. please add a good comment describing the encryption approach. AES-GCM with key size, nonce size. How we generate a nonce for each. |
||
| gcm cipher.AEAD | ||
| key []byte | ||
| } | ||
|
|
||
| func NewEncryptor(key []byte) (*Encryptor, error) { | ||
| if len(key) != 32 { | ||
| return nil, fmt.Errorf("key must be 32 bytes long") | ||
| } | ||
|
|
||
| block, err := aes.NewCipher(key) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| gcm, err := cipher.NewGCM(block) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &Encryptor{gcm: gcm, key: key}, nil | ||
| } | ||
|
|
||
| func (e *Encryptor) Encrypt(plaintext []byte) ([]byte, error) { | ||
| nonce := make([]byte, e.gcm.NonceSize()) | ||
| if _, err := io.ReadFull(rand.Reader, nonce); err != nil { | ||
| return nil, err | ||
| } | ||
| return e.gcm.Seal(nonce, nonce, plaintext, nil), nil | ||
| } | ||
|
|
||
| func (e *Encryptor) Decrypt(ciphertext []byte) ([]byte, error) { | ||
| if len(ciphertext) < e.gcm.NonceSize() { | ||
| return nil, errors.New("ciphertext too short") | ||
| } | ||
| nonce, ciphertext := ciphertext[:e.gcm.NonceSize()], ciphertext[e.gcm.NonceSize():] | ||
| return e.gcm.Open(nil, nonce, ciphertext, nil) | ||
| } | ||
|
|
||
| func (e *Encryptor) HashWithHMAC(data []byte) []byte { | ||
| h := hmac.New(sha256.New, e.key) | ||
|
There was a problem hiding this comment. this should not be reused (it has it's internal state and by reusing we might get different outputs) |
||
| h.Write(data) | ||
| return h.Sum(nil) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| package encryption | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "crypto/rand" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestNewEncryptor(t *testing.T) { | ||
| key := make([]byte, 32) // 256-bit key | ||
| _, err := rand.Read(key) | ||
| if err != nil { | ||
| t.Fatalf("Failed to generate random key: %v", err) | ||
| } | ||
|
|
||
| encryptor, err := NewEncryptor(key) | ||
| if err != nil { | ||
| t.Fatalf("NewEncryptor failed: %v", err) | ||
| } | ||
|
|
||
| if encryptor == nil { | ||
| t.Fatal("NewEncryptor returned nil") | ||
| } | ||
| } | ||
|
|
||
| func TestEncryptDecrypt(t *testing.T) { | ||
| key := make([]byte, 32) // 256-bit key | ||
| _, err := rand.Read(key) | ||
| if err != nil { | ||
| t.Fatalf("Failed to generate random key: %v", err) | ||
| } | ||
|
|
||
| encryptor, err := NewEncryptor(key) | ||
| if err != nil { | ||
| t.Fatalf("NewEncryptor failed: %v", err) | ||
| } | ||
|
|
||
| plaintext := []byte("Hello, World!") | ||
|
|
||
| ciphertext, err := encryptor.Encrypt(plaintext) | ||
| if err != nil { | ||
| t.Fatalf("Encryption failed: %v", err) | ||
| } | ||
|
|
||
| decrypted, err := encryptor.Decrypt(ciphertext) | ||
| if err != nil { | ||
| t.Fatalf("Decryption failed: %v", err) | ||
| } | ||
|
|
||
| if !bytes.Equal(plaintext, decrypted) { | ||
| t.Fatalf("Decrypted text does not match original plaintext") | ||
| } | ||
| } | ||
|
|
||
| func TestEncryptDecryptEmptyString(t *testing.T) { | ||
| key := make([]byte, 32) // 256-bit key | ||
| _, err := rand.Read(key) | ||
| if err != nil { | ||
| t.Fatalf("Failed to generate random key: %v", err) | ||
| } | ||
|
|
||
| encryptor, err := NewEncryptor(key) | ||
| if err != nil { | ||
| t.Fatalf("NewEncryptor failed: %v", err) | ||
| } | ||
|
|
||
| plaintext := []byte("") | ||
|
|
||
| ciphertext, err := encryptor.Encrypt(plaintext) | ||
| if err != nil { | ||
| t.Fatalf("Encryption of empty string failed: %v", err) | ||
| } | ||
|
|
||
| decrypted, err := encryptor.Decrypt(ciphertext) | ||
| if err != nil { | ||
| t.Fatalf("Decryption of empty string failed: %v", err) | ||
| } | ||
|
|
||
| if !bytes.Equal(plaintext, decrypted) { | ||
| t.Fatalf("Decrypted empty string does not match original") | ||
| } | ||
| } | ||
|
|
||
| func TestDecryptInvalidCiphertext(t *testing.T) { | ||
| key := make([]byte, 32) // 256-bit key | ||
| _, err := rand.Read(key) | ||
| if err != nil { | ||
| t.Fatalf("Failed to generate random key: %v", err) | ||
| } | ||
|
|
||
| encryptor, err := NewEncryptor(key) | ||
| if err != nil { | ||
| t.Fatalf("NewEncryptor failed: %v", err) | ||
| } | ||
|
|
||
| invalidCiphertext := []byte("This is not a valid ciphertext") | ||
|
|
||
| _, err = encryptor.Decrypt(invalidCiphertext) | ||
| if err == nil { | ||
| t.Fatal("Decryption of invalid ciphertext should have failed, but didn't") | ||
| } | ||
| } | ||
|
|
||
| func TestNewEncryptorInvalidKeySize(t *testing.T) { | ||
| invalidKey := make([]byte, 31) // Invalid key size (not 16, 24, or 32 bytes) | ||
| _, err := rand.Read(invalidKey) | ||
| if err != nil { | ||
| t.Fatalf("Failed to generate random key: %v", err) | ||
| } | ||
|
|
||
| _, err = NewEncryptor(invalidKey) | ||
| if err == nil { | ||
| t.Fatal("NewEncryptor should have failed with invalid key size, but didn't") | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is an ID field in the EncryptedDocument as well.
Is this one here necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No necessary, removed now.