Fix Gateway frontend dockerfile #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badgersrus
approved these changes
Nov 4, 2024
|
|
||
| # Build the Next.js app | ||
| RUN pnpm run build | ||
|
|
||
| # Reduce the size of the final image by using a lighter base image | ||
| FROM node:20-alpine AS runner | ||
|
|
||
| # Install pnpm | ||
| RUN npm install -g pnpm |
There was a problem hiding this comment.
I think this one is redundant since its installed at the start? Not sure if that --prod flag works the same with pnpm at the latter stage but maybe @pbienek might know more
There was a problem hiding this comment.
It is a different image (base and runner image) and it needs pnpm installed.
As far as I know --prod flag doesn't install dev dependencies which makes runner image smaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Currently docker container doesn't build. It needs fixing to be able to be deployed from main.
What changes were made as part of this PR
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks