Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix address compare #2175

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix address compare #2175

merged 2 commits into from
Dec 3, 2024

Conversation

tudor-malene
Copy link
Collaborator

Why this change is needed

This addresses the performance issue we've been seeing.
The receipt cache was not used

What changes were made as part of this PR

  • compare Addresses instead of pointers to addresses. (thanks golang)

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Contributor

@badgersrus badgersrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - good job finding these 😅

@tudor-malene tudor-malene merged commit 74a6256 into main Dec 3, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/fix_receipt_cache branch December 3, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants