Store certificate and private key in encrypted CosmosDB database #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-malene
reviewed
Dec 3, 2024
| } | ||
|
|
||
| // dbKey generates a consistent key for CosmosDB storage | ||
| func (c *CertStorageCosmosDB) dbKey(key []byte) (string, azcosmos.PartitionKey) { |
There was a problem hiding this comment.
I don't think we need to obfuscate the key. There will be only one
There was a problem hiding this comment.
First 2 are old (obfuscated keys) and the last two are keys after the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
We want to have static https certificate (using the same private key) even after restarts & certificate renewals etc.
Certificate and private key were previously stored in memory and in file on attached volume.
This is not ideal as it is stored unencrypted and in case of volume is deleted the private key and certificate are deleted.
Much better solution is to store both private key and certificate in encrypted CosmosDB.
What changes were made as part of this PR
autocert.Cachein which we store certificate and private key in cosmosDB and encrypt it.PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks