Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caching for event topics and contract address #2202

Merged
merged 2 commits into from
Dec 13, 2024
Merged

caching for event topics and contract address #2202

merged 2 commits into from
Dec 13, 2024

Conversation

tudor-malene
Copy link
Collaborator

@tudor-malene tudor-malene commented Dec 13, 2024 •
edited
Loading

Why this change is needed

  • to improve performance
  • fix for gateway when running against a different network ( which happens during redeploys)

What changes were made as part of this PR

  • add caching for event topics
  • use the contract cache everywhere
  • add error handling when executing sensitive requests to read the key and retry

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

BedrockSquirrel
BedrockSquirrel approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tudor-malene tudor-malene merged commit 75ef65b into main Dec 13, 2024
23 of 24 checks passed
@tudor-malene tudor-malene deleted the tudor/perf_fixes branch December 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BedrockSquirrel BedrockSquirrel BedrockSquirrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tudor-malene @BedrockSquirrel @moraygrieve