Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local testnet: fix node starter param #2208

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

BedrockSquirrel
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel commented Dec 16, 2024

Why this change is needed

This PR broke the local testnet starter script (which breaks the e2e tests).

Auto-refactor of a method had it trying to start the nodes with 0 enclaves instead of 1.

Missed updating launcher config with new indexed naming convention for enclaves.

What changes were made as part of this PR

Fix the param and config.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BedrockSquirrel BedrockSquirrel merged commit e83dbec into main Dec 17, 2024
2 checks passed
@BedrockSquirrel BedrockSquirrel deleted the matt/fix-local-testnet-startup branch December 17, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants