persistent volume and option to deploy to the same VM #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
At the moment when we redeploy TEN Gateway we delete and recreate whole VM which deletes also the volume where the encryption key is sealed. Since we store certificates in cosmosDB encrypted and we don't get the encryption key from previous version of the gateway we cannot read old certificates resulting in certificate error.
What changes were made as part of this PR
New option when deploying to redeploy to the same VM (volume and sealed encryption key stays there) so we can easily redeploy the gateway without issues with the certificate.
Since we don't need to delete and recreate VM on Azure it also reduces deployment time. In case we want to make fresh deployment when we have some larger changes we can still do it by selecting it in github actions.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks