Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edb-connect: fix edb default host and allow caller to set it #2214

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

BedrockSquirrel
Copy link
Collaborator

Why this change is needed

We changed the edb default host name (obscuronode-edgelessdb-0). Allowing us to set it means the tool can still be used for sepolia and for the HA db (obscuronode-edgelessdb-1).

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BedrockSquirrel BedrockSquirrel merged commit 6328e9a into main Dec 18, 2024
3 checks passed
@BedrockSquirrel BedrockSquirrel deleted the matt/fix-edb-connect-credentials branch December 18, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants