Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize mutexes and increase batch size #2215

Merged
merged 5 commits into from
Dec 19, 2024
Merged

optimize mutexes and increase batch size #2215

merged 5 commits into from
Dec 19, 2024

Conversation

tudor-malene
Copy link
Collaborator

@tudor-malene tudor-malene commented Dec 18, 2024 •
edited
Loading

Why this change is needed

  • this enables batches and rollups to be created in parallel. (to avoid pauses in batch creation when rollups are created)
  • bump the batch size to 128kb - which is the max tx size (to avoid txs remaining in the mempool)

StefanIliev545
StefanIliev545 reviewed Dec 18, 2024
View reviewed changes
go/config/defaults/0-base-config.yaml
@@ -8,11 +8,11 @@ network:
batch:
interval: 1s
maxInterval: 1s # if this is greater than batch.interval then we make batches more slowly when there are no transactions
maxSize: 45000 # around 45kb - around 200 transactions / batch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was a reason we picked batch size to be lower but i cant recall. The only thing i recall as a hard limit was 64kb for accepting eth transactions in the geth code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually rollups had more metadata than batches so there was an overhead that needed to be free, if rollups match batch size we might have issues

StefanIliev545
StefanIliev545 reviewed Dec 18, 2024
View reviewed changes
go/config/defaults/0-base-config.yaml
rollup:
interval: 5s
maxInterval: 10m # rollups will be produced after this time even if the data blob is not full
maxSize: 131072 # 128kb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do blobs have any overhead on top of rollup metadata? @badgersrus

StefanIliev545
StefanIliev545 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@StefanIliev545 StefanIliev545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tudor-malene tudor-malene merged commit 05b9147 into main Dec 19, 2024
2 checks passed
@tudor-malene tudor-malene deleted the tudor/optimize_mutexes branch December 19, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanIliev545 StefanIliev545 StefanIliev545 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tudor-malene @StefanIliev545