-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow block processing to continue with failed rollups #2285
Conversation
…ething is not aligning properly
…ll/rework-block-rejection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is on the right track, but it's quite hard to reason about because of the "block-centric" approach.
Currently (in ingestL1Block
) we do:
- GetRollups - which does all sorts of stuff, from decoding, verifying to verifying signatures.
- Store Block
- Process Rollups - the execution and storage
It's hard to reason about errors.
What if we did the following:
- Store Block
- For every l1 event of type:
common.RollupTx
callProcessRollup
, which will do the usual:
a. Check sequencer signature - we can do this first because the hash in in the header
b. extract the blob
c. decode
d. verify the hashes
e. ReconstructRollup
f. pass it to the compression service to Process the rollup
…liev/update-header-signatures
@tudor-malene just FYI the processing order above won't work as we need the blob hashes to create the composite hash (its not in the header) so a) will need to come after d) but this will still be easier to follow in this flow. |
closing to use a fresh branch as the rebase has a nightmare |
Why this change is needed
https://github.com/ten-protocol/ten-internal/issues/4522
What changes were made as part of this PR
ErrCriticalRollupProcessing
error type that we wrap if we fail the rollup processing after we've verified the rollup was signed by the enclavePR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks