Simplify ThemeResources::CheckIfExists()

Use std::unordered_map::find() instead of testing if a condition will throw. Also fixes an MSVC warning about ignoring a nodiscard function. Signed-off-by: Avery King <[email protected]>
tenacityteam · May 12, 2024 · 2054ce4 · 2054ce4
1 parent 6269065
commit 2054ce4
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/libraries/lib-theme/ThemeResources.cpp b/libraries/lib-theme/ThemeResources.cpp
@@ -31,15 +31,7 @@ std::any& ThemeResources::GetResourceData(const std::string& name)
 
 bool ThemeResources::CheckIfExists(const std::string& name) const
 {
-    try
-    {
-        mResources.at(name);
-    } catch (std::out_of_range&)
-    {
-        return false;
-    }
-
-    return true;
+    return mResources.find(name) != mResources.end();
 }
 
 ThemeResources::ThemeResourceList ThemeResources::GetRegisteredResourceNames() const