fix vpc acl inconsistent when port is ALL #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyu571
reviewed
Sep 20, 2023
| if info.EgressEntries[i].Protocol != nil { | ||
| protocol = *info.EgressEntries[i].Protocol | ||
| } | ||
|
|
||
| result := strings.Join([]string{ |
There was a problem hiding this comment.
除了Port为空时，需给默认值"ALL"。
其余3个参数也需要额外判空？原逻辑不满足要求吗？
There was a problem hiding this comment.
除了Port为空时，需给默认值"ALL"。 其余3个参数也需要额外判空？原逻辑不满足要求吗？
后面要取值的，如果没返回值，直接*，会crash的。譬如之后如果支持ipv6规则，如果直接取cidr值，便会直接crash。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.