Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import node-pool #2138

Merged
merged 1 commit into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/2138.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新加的功能是不是要补充下e2e测试

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试大佬测试过

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试大佬测试过

需要在 tencentcloud/resource_tc_kubernetes_node_pool_test.go 中补充e2e自动化测试覆盖

resource/tencentcloud_kubernetes_node_pool: set up the node pool and import it into Terraform
```
3 changes: 3 additions & 0 deletions tencentcloud/extension_as.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const (
SYSTEM_DISK_TYPE_CLOUD_PREMIUM = "CLOUD_PREMIUM"
SYSTEM_DISK_TYPE_CLOUD_SSD = "CLOUD_SSD"
SYSTEM_DISK_TYPE_CLOUD_HSSD = "CLOUD_HSSD"
SYSTEM_DISK_TYPE_CLOUD_BSSD = "CLOUD_BSSD"
SYSTEM_DISK_TYPE_CLOUD_TSSD = "CLOUD_TSSD"
)

Expand All @@ -18,6 +19,7 @@ var SYSTEM_DISK_ALLOW_TYPE = []string{
SYSTEM_DISK_TYPE_CLOUD_SSD,
SYSTEM_DISK_TYPE_CLOUD_HSSD,
SYSTEM_DISK_TYPE_CLOUD_TSSD,
SYSTEM_DISK_TYPE_CLOUD_BSSD,
}

const (
Expand Down Expand Up @@ -47,6 +49,7 @@ const (

const (
SCALING_GROUP_RETRY_POLICY_IMMEDIATE_RETRY = "IMMEDIATE_RETRY"
SCALING_GROUP_RETRY_POLICY_NO_RETRY = "NO_RETRY"
SCALING_GROUP_RETRY_POLICY_INCREMENTAL_INTERVALS = "INCREMENTAL_INTERVALS"
)

Expand Down
9 changes: 9 additions & 0 deletions tencentcloud/internal/helper/transform.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,21 @@ func PString(pointer *string) string {
}
return *pointer
}
func PBool(pointer *bool) bool {
if pointer == nil {
return false
}
return *pointer
}

func PUint64(pointer *uint64) uint64 {
return *pointer
}

func PInt64(pointer *int64) int64 {
if pointer == nil {
return 0
}
return *pointer
}

Expand Down
Loading